wp plugin update-all enters maintenance mode even when no updates are available

[om4james]

When executing wp plugin update-all on a site with no plugin updates, the output is as follows:

Enabling Maintenance mode... Disabling Maintenance mode... Success: Updated 0/0 plugins.

I think ideally we shouldn't enter maintenance mode at all if no updates are available.

I suspect theme and possibly core updates might need the same enhancement as well.

[scribu]

WP-CLI just uses the bulk upgrader from WordPress, so you should file a bug upstream:

http://core.trac.wordpress.org/

[om4james]

Thanks for the quick reply.

Upon further investigation, this only occurs when using WordPress Multisite:

wp plugin update-all Enabling Maintenance mode... Disabling Maintenance mode... Success: Updated 0/0 plugins.

Normal WordPress simply outputs:

wp plugin update-all Success: Updated 0/0 plugins.

I agree though @scribu, sounds like a fix is needed in WordPress core.

[om4james]

@scribu, this commit is one way to fix this in wp-cli.

The other would be for me to submit a patch for WordPress core that adds checks to Plugin_Upgrader::bulk_upgrade() and Theme_Upgrader::bulk_upgrade() only act if the array passed to them isn't empty.

[scribu]

The other would be for me to submit a patch for WordPress core that adds checks to Plugin_Upgrader::bulk_upgrade() and Theme_Upgrader::bulk_upgrade() only act if the array passed to them isn't empty.

Please do that anyway, regardless of what WP-CLI does.

[om4james]

Core bug report: http://core.trac.wordpress.org/ticket/24496
Pull Request: #492

Thanks @scribu.

[om4james]

Core bug report: http://core.trac.wordpress.org/ticket/24496

This bug has now been fixed in core and will be included in WordPress 3.7.