Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some strings to be translated are not included in the erp.php and erp.pot files #1415

Open
DAnn2012 opened this issue Apr 13, 2023 · 2 comments

Comments

@DAnn2012
Copy link
Contributor

DAnn2012 commented Apr 13, 2023

Some strings to be translated are not included in the erp.php file (which as @RatulHasan clarified to me is an auto-generated php file #1400 (comment), as is the erp.pot file).

These are the strings and where they are placed in the source code:

__( 'For the period of (Transaction date)', 'erp' ),

<strong>{{ __('For the period of (Transaction date)', 'erp') }}:</strong>

<strong>{{ __( 'For the period of (Transaction date)', 'erp' ) }}:</strong>

<strong>{{ __( 'For the period of (Transaction date)', 'erp' ) }}:</strong>


__( 'For the period of ( Transaction date )', 'erp' ),

<strong>{{ __('For the period of ( Transaction date )', 'erp') }}:</strong>

<li><strong>{{ __('For the period of ( Transaction date )', 'erp') }}:</strong> <em>{{ formatDate(start_date) }}</em> to <em>{{ formatDate(end_date) }}</em></li>

<p><strong>{{ __('For the period of ( Transaction date )', 'erp') }}:</strong> <em>{{ start_date }}</em> to <em>{{ end_date }}</em></p>

<p><strong>{{ __('For the period of ( Transaction date )', 'erp') }}:</strong> <em>{{ start_date }}</em> {{ __('to', 'erp') }} <em>{{ end_date }}</em></p>


__( 'For the period of ( Opening Balance date )', 'erp' ),

<li><strong>{{ __('For the period of ( Opening Balance date )', 'erp') }}:</strong> <em>{{ fin_year.start_date }}</em> {{ __('to', 'erp') }} <em>{{ fin_year.end_date }}</em></li>


__( 'Selecting tax category is important if you want to have tax on that product while selling.', 'erp' ),

<label>{{ __('Tax Category', 'erp') }} <span class="erp-help-tip .erp-tips" :title="__('Selecting tax category is important if you want to have tax on that product while selling.', 'erp')"></span></label>


__( 'Code (optional)', 'erp' ),

<label for="">{{ __('Code (optional)', 'erp') }}</label>


__( 'Sales Tax Report (Customer Based)', 'erp' ),

<span>{{ __( 'Sales Tax Report (Customer Based)', 'erp' ) }}</span>


__( 'Sales Tax Report (Transaction Based)', 'erp' ),

<span>{{ __( 'Sales Tax Report (Transaction Based)', 'erp' ) }}</span>


__( 'Sales Tax Report (Agency Based)', 'erp' ),

<span>{{ __( 'Sales Tax Report (Agency Based)', 'erp' ) }}</span>


__( 'Sales Tax Report (Category Based)', 'erp' ),

<span>{{ __( 'Sales Tax Report (Category Based)', 'erp' ) }}</span>


__( 'Save Conversion', 'erp' ),

<combo-button :options="[{ id: 'update', text: __('Save Conversion', 'erp') }]" />

<combo-button v-if="draftToExpense()" :options="[{ id: 'update', text: __('Save Conversion', 'erp') }]" />

<combo-button :options="[{ id: 'update', text: __('Save Conversion', 'erp') }]" />


And this strings in /erp/vendor/appsero/client/src/Insights.php:

__( 'Want to help make <strong>%1$s</strong> even more awesome? Allow %1$s to collect non-sensitive diagnostic data and usage information.', 'erp' ),

$notice = sprintf( $this->client->__trans( 'Want to help make <strong>%1$s</strong> even more awesome? Allow %1$s to collect non-sensitive diagnostic data and usage information.' ), $this->client->name );

__( 'what we collect', 'erp' ),

$notice .= ' (<a class="' . $this->client->slug . '-insights-data-we-collect" href="#">' . $this->client->__trans( 'what we collect' ) . '</a>)';

__( 'Allow', 'erp' ),

echo ' <a href="' . esc_url( $optin_url ) . '" class="button-primary button-large">' . $this->client->__trans( 'Allow' ) . '</a>';

__( 'No thanks', 'erp' ),

echo ' <a href="' . esc_url( $optout_url ) . '" class="button-secondary button-large">' . $this->client->__trans( 'No thanks' ) . '</a>';

...and all other strings that are in the source code of this file in "__trans", "_etrans" or directly as text.


Thanks.

@DAnn2012
Copy link
Contributor Author

Hi @RatulHasan and @Rat01047 ,

please could you kindly take a look at this my Issue report?

Thank you.

@DAnn2012
Copy link
Contributor Author

Hi @mrabbani ,

please could you kindly take a look at this my Issue report?

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants