Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP 5.7 Cover Blocks not displaying correctly with webp/picture tags enabled #546

Closed
5 of 6 tasks
iCaspar opened this issue Mar 11, 2021 · 3 comments · Fixed by #554
Closed
5 of 6 tasks

WP 5.7 Cover Blocks not displaying correctly with webp/picture tags enabled #546

iCaspar opened this issue Mar 11, 2021 · 3 comments · Fixed by #554

Comments

@iCaspar
Copy link
Contributor

iCaspar commented Mar 11, 2021

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
Reported on the WP Plugin Support (🎩-tip to Michael Bourne).

... the new WP 5.7 update has changed cover blocks to use an image element as the background. With webp enabled using <picture> tags, the display of these images is incorrect.

Reproduced locally, see example screenshot:
Screen Shot 2021-03-11 at 9 35 32 AM

To Reproduce
Steps to reproduce the behavior:

  1. In any post using the WP 5.7 Cover Block, add an image and text.
  2. Save Imagify settings to "Create Webp" images > "Display images in webp format" and "Use <picture> tags".
  3. View the incorrect display on the page.

Expected behavior
Webp images in the new Cover Block element should display as a completely covered background behind the text.

Backlog Grooming (for WP Media dev team use only)

  • Reproduce the problem -- Reproduced locally, See Screenshot
  • Identify the root cause -- Imagify does not add the correct CSS for the cover image to display properly.
  • Scope a solution -- Image will display properly with additional CSS. Mr. Bourne's solution pasted here as example of working CSS:

.wp-block-cover-image picture.wp-block-cover__image-background,
.wp-block-cover picture.wp-block-cover__image-background {
	position: absolute;
	top: 0;
	left: 0;
	right: 0;
	bottom: 0;
	margin: 0;
	padding: 0;
	width: 100%;
	height: 100%;
}
.wp-block-cover-image picture.wp-block-cover__image-background > img,
.wp-block-cover picture.wp-block-cover__image-background > img {
	position: absolute;
	top: 0;
	left: 0;
	right: 0;
	bottom: 0;
	margin: 0;
	padding: 0;
	width: 100%;
	height: 100%;
	max-width: none;
	max-height: none;
	-o-object-fit: cover;
	object-fit: cover;
	outline: none;
	border: none;
	box-shadow: none;
}

That said, currently, Imagify does not output styles on the front end, leaving themes to do the styling. We will need to explore whether we want to provide some block styling in this instance, and if so, provide for rendering styles on the front end.

  • Estimate the effort
@michaelbourne
Copy link
Contributor

I've created a PR to address this without additional CSS.

@michaelbourne
Copy link
Contributor

Do you have an ETA for 1.9.15?

@Tabrisrp
Copy link
Contributor

@michaelbourne Current plan is to have this version available mid-July. Our team has been busy on another product lately, but we want to make sure we have this new version before WP 5.8 release.

Thank you for your patience 🙏🏼

@iCaspar iCaspar mentioned this issue Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants