Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting data-no-lazy to 1 on images does not work since 1.4.8 #59

Closed
janvitos opened this issue Jul 4, 2018 · 5 comments
Closed

Setting data-no-lazy to 1 on images does not work since 1.4.8 #59

janvitos opened this issue Jul 4, 2018 · 5 comments

Comments

@janvitos
Copy link

janvitos commented Jul 4, 2018

Hi,

I noticed setting data-no-lazy to 1 on images does not work anymore in version 1.4.8. The plugin still lazy loads the images that have the flag set while it should skip them.

Thanks.

@janvitos janvitos changed the title Setting data-no-lazy to 1 does not work since 1.4.8 Setting data-no-lazy to 1 on images does not work since 1.4.8 Jul 4, 2018
@janvitos
Copy link
Author

janvitos commented Jul 5, 2018

Any update on this?

@Tabrisrp
Copy link
Contributor

The image might have the class lazyloaded added to it, but it doesn't mean it has been.

Is there a data-lazy-src attribute, and a noscript tag following the image? If not, it means the exclusion works correctly

@notatamas
Copy link

I can confirm that this issue is not fixed yet.

@janvitos
Copy link
Author

janvitos commented Jan 4, 2019

You can temporarily fix this problem while they work on the issue by adding this line to your functions.php file:

remove_filter( 'wp_get_attachment_image_attributes', 'rocket_lazyload_get_attachment_image', 11 );

I'm not sure what impact this might have on other features of the plugin, so be careful. But it had none for me whatsoever and made data-no-lazy work again.

@janvitos
Copy link
Author

janvitos commented Jan 9, 2019

Fixed in new version.

@janvitos janvitos closed this as completed Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants