Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache recreated on each page load when WebP Caching is enabled #2158

Closed
piotrbak opened this issue Dec 5, 2019 · 1 comment · Fixed by #2147
Closed

Cache recreated on each page load when WebP Caching is enabled #2158

piotrbak opened this issue Dec 5, 2019 · 1 comment · Fixed by #2147
Assignees
@Tabrisrp
Labels
module: media needs: testing type: bug Indicates an unexpected problem or unintended behavior
Milestone
3.5

Comments

@piotrbak
Copy link
Contributor

piotrbak commented Dec 5, 2019 •
edited

This is a very similar case to this one:
#2156

When WebP Caching is enabled but $_SERVER array doesn't include image/webp value in the HTTP_ACCEPT, the get_cache_path function returns path without -webp.

wp-rocket/inc/classes/Buffer/class-cache.php

Line 286 in 7723e78

$cache_filepath = $this->get_cache_path( [ 'webp' => $has_webp ] );

@crystinutzaa has already investigated this problem.

Related tickets:
https://secure.helpscout.net/conversation/1005343810/131288/
@Tabrisrp
Copy link
Contributor

I believe this should be fixed with the change here: https://github.com/wp-media/wp-rocket/pull/2147/files#diff-094b220e4f6e0e5e459bd40cbe4fafe8

I found it when doing testing for the #2147 PR changes, and it will be included in 3.5.

@Tabrisrp Tabrisrp added module: media needs: testing type: bug Indicates an unexpected problem or unintended behavior labels Dec 11, 2019
@arunbasillal arunbasillal added this to the 3.5 milestone Jan 20, 2020
@vmanthos vmanthos mentioned this issue Jan 24, 2020
Closed
4 tasks
@Tabrisrp Tabrisrp linked a pull request Feb 13, 2020 that will close this issue
Fixes #1945 cache race condition with multiple servers #2147
Merged
@Tabrisrp Tabrisrp self-assigned this Feb 27, 2020
@Tabrisrp Tabrisrp closed this as completed Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tabrisrp Tabrisrp

Labels
module: media needs: testing type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
3.5
Development

Successfully merging a pull request may close this issue.

Fixes #1945 cache race condition with multiple servers wp-media/wp-rocket
3 participants
@Tabrisrp @arunbasillal @piotrbak