Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter to stop purge cache #258

Closed
jakubkaderavek opened this issue Dec 13, 2016 · 5 comments
Closed

Add filter to stop purge cache #258

jakubkaderavek opened this issue Dec 13, 2016 · 5 comments
Labels
feature request Indicates new feature requests wontfix Indicates that work won't continue on an issue or pull request

Comments

@jakubkaderavek
Copy link

jakubkaderavek commented Dec 13, 2016

Hi,

there is a problem when I save draft, then all urls are purged when I update post, cache comment count etc. so it would by great if you add filter like:

$stop_purge = apply_filters( 'before_rocket_purge_post', $post);
if($stop_purge == false) {
return;
}

to inc/common/purge.php to stop execute of function.

@GeekPress
Copy link
Contributor

GeekPress commented Dec 13, 2016

Hi @jakubkaderavek You can also directly remove our filter instead of creating a new one like this:
remove_action( 'clean_post_cache' , 'rocket_clean_post' );

I will also suggest you to open a ticket support: https://wp-rocket.me/support

By default, the normal behavior is no purge is triggered if a post is in draft.

@jakubkaderavek
Copy link
Author

Hi @GeekPress ,
thanks for reply - I try to remove action but I test WP Rocket and cache is purged when you save draft (it's not pruged when is auto-draft). We discuss this with Remy frm WP Rocket

@foliovision
Copy link
Contributor

@jakubkaderavek WP Rocket does too many cache purges, we posted some summary here: #478

@Tabrisrp Tabrisrp added the feature request Indicates new feature requests label Nov 23, 2019
@Tabrisrp
Copy link
Contributor

Seems to be related to #2124

@GeekPress GeekPress added the wontfix Indicates that work won't continue on an issue or pull request label May 21, 2020
@GeekPress
Copy link
Contributor

I'm closing it as the purge issue when a post is saved as draft as been fixed with WP Rocket 3.4.3 (#2124)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Indicates new feature requests wontfix Indicates that work won't continue on an issue or pull request
Projects
None yet
Development

No branches or pull requests

4 participants