Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preload - Treat Redirected URLs status as redirected #5543

Open
2 of 6 tasks
mehedihasanziku opened this issue Nov 3, 2022 · 0 comments
Open
2 of 6 tasks

Preload - Treat Redirected URLs status as redirected #5543

mehedihasanziku opened this issue Nov 3, 2022 · 0 comments
Labels
module: preload priority: low Issues that can wait type: enhancement Improvements that slightly enhance existing functionality and are fast to implement

Comments

@mehedihasanziku
Copy link

mehedihasanziku commented Nov 3, 2022

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
I tested preload feature on a complicated website. so far i found an issue.

When a page discovered inside sitemap and it has 301 redirection, this redirection never cleared from in-progress, a never ending preload process here.

sql queries to check,
Total stats:

SELECT status, count(1) FROM `wp_wpr_rocket_cache` group by status 

Filter URLs in-progress :

SELECT * FROM `wp_wpr_rocket_cache` WHERE status = "in-progress" 

This part causing issues with preload batch 45 URLs per minute. it's filling some quota of 45, let's assume if one website has 20 redirection in-progress everytime, it will be 25 URLs per minute, and preload is slow.

To Reproduce
Steps to reproduce the behavior:

  1. create 301 redirection and make sure that page listed inside sitemap and monitor inside database

Expected behavior
Expected 301 redirection url will be marked as redirected, and original page will be cached, as it will be discovered inside sitemap again.

Screenshots
N/A

Additional context
This site using HTTPS, But redirection using for such pages https > http , I know not good, but still preload should not be busy with such urls.

Backlog Grooming (for WP Media dev team use only)

  • Reproduce the problem
  • Identify the root cause
  • Scope a solution
  • Estimate the effort
@piotrbak piotrbak added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement module: preload priority: low Issues that can wait labels Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: preload priority: low Issues that can wait type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

No branches or pull requests

2 participants