Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License is not activating with fresh installations in some cases #5866

Closed
4 tasks
engahmeds3ed opened this issue Apr 12, 2023 · 0 comments · Fixed by #5867
Closed
4 tasks

License is not activating with fresh installations in some cases #5866

engahmeds3ed opened this issue Apr 12, 2023 · 0 comments · Fixed by #5867
Assignees
Labels
Module: dashboard module: filesystem priority: high Issues which should be resolved as quickly as possible severity: critical Defect that prevents the testing/use of the software type: bug Indicates an unexpected problem or unintended behavior
Milestone

Comments

@engahmeds3ed
Copy link
Contributor

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version Yes
  • Used the search feature to ensure that the bug hasn’t been reported before Yes

Describe the bug

We noticed that starting from 3.13 the license activation for fresh installations are not working in some cases, so the licence-data.php is removed and the license is validated in the first time but then when opening the settings page we see the license validation page which has empty fields.

After digging into this I found that the license is validated at first successfully and then when dynamic lists are grabbed from our backend API and saved, we try to save the options again but seems like this is getting our settings option as empty array so the license details are removed from our options.

public function refresh_exclusions_option() {
$selected_items = $this->options->get( 'delay_js_exclusions_selected', [] );
$this->options->set(
'delay_js_exclusions_selected_exclusions',
$this->get_delayjs_items_exclusions( $selected_items )
);
$this->options_api->set( 'settings', $this->options->get_options() );
}

To Reproduce

  1. Fresh install wp rocket
  2. Check the settings page
  3. licence-data.php is removed but the license details' fields are empty.

Expected behavior
License should be validated properly.

Backlog Grooming (for WP Media dev team use only)

  • Reproduce the problem
  • Identify the root cause
  • Scope a solution
  • Estimate the effort
@engahmeds3ed engahmeds3ed self-assigned this Apr 12, 2023
@piotrbak piotrbak added Module: dashboard priority: high Issues which should be resolved as quickly as possible module: filesystem severity: critical Defect that prevents the testing/use of the software type: bug Indicates an unexpected problem or unintended behavior labels Apr 12, 2023
@piotrbak piotrbak added this to the 3.13.0.2 milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: dashboard module: filesystem priority: high Issues which should be resolved as quickly as possible severity: critical Defect that prevents the testing/use of the software type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants