Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate query when checking rucss table #6068

Closed
4 tasks
webtrainingwheels opened this issue Jul 26, 2023 · 2 comments · Fixed by #6140
Closed
4 tasks

Duplicate query when checking rucss table #6068

webtrainingwheels opened this issue Jul 26, 2023 · 2 comments · Fixed by #6140
Assignees
Labels
effort: [XS] < 1 day of estimated development time module: remove unused css priority: low Issues that can wait type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Milestone

Comments

@webtrainingwheels
Copy link

webtrainingwheels commented Jul 26, 2023

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
There is a duplicate query when we check if the RUCSS table exists.
SHOW TABLES LIKE 'wp\\_wpr\\_rucss\\_used\\_css

To Reproduce
Steps to reproduce the behavior:

  1. Enable Query Monitor plugin
  2. View the Duplicate Queries
  3. See the duplicate query: https://jumpshare.com/v/TDhTbgX5P5Wz3gb8ByiF

Expected behavior
No duplicate query

Screenshots
https://jumpshare.com/v/TDhTbgX5P5Wz3gb8ByiF

Per @engahmeds3ed :

It easily can be fixed here
by replacing add with share
this will create only one instance from the table class and share it with whatever class calls it.

Original Ticket: https://secure.helpscout.net/conversation/2305707443/431357?folderId=377611

Backlog Grooming (for WP Media dev team use only)

  • Reproduce the problem
  • Identify the root cause
  • Scope a solution
  • Estimate the effort
@piotrbak piotrbak added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement priority: low Issues that can wait module: remove unused css labels Aug 1, 2023
@engahmeds3ed
Copy link
Contributor

Already groomed during escalation.

Effort [XS]

@engahmeds3ed engahmeds3ed added the effort: [XS] < 1 day of estimated development time label Aug 8, 2023
@CrochetFeve0251 CrochetFeve0251 self-assigned this Sep 5, 2023
@piotrbak piotrbak added this to the 3.15.1 milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: [XS] < 1 day of estimated development time module: remove unused css priority: low Issues that can wait type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants