-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image URL with special character isnot handled correctly with LCP/ATF #6339
Comments
We need to make sure this will also happen on the new version. As it's leftover from the previous project, but it looks like it might happen here too. @MathieuLamiot How you'd handle this? I think it should be checked and fixed at the end, actually. |
If the issue can be reproduced and is linked to applying the optimization from the DB to the HTML, then it can be done now. |
Checking this one now... |
@wordpressfan @Khadreal, is it possible to reproduce and investigate currently or do you prefer to block it for now as suggested yesterday, waiting for a more complete version to be able to test? |
OK, let me move my comment from slack here for reference: I can see that fetchpriority in both locations by doing the following steps:
So if the data is saved correctly into the database, this fetchpriority will be added in both locations, at this point we can't validate the other part of saving the data into the database so I believe this should be blocked till we have a working version in both directions (saving and retrieving from the DB) |
Crystal clear, thanks 🙏 |
Based on @wordpressfan description and @Mai-Saad's investigation here, this is closed as a duplicate of #6524 |
Before submitting an issue please check that you’ve completed the following steps:
Describe the bug
While having LCP/ATF image with a special character, the image is not excluded from lazyload and is not have
fetchpriority="high"
beside image markup when it is LCPTo Reproduce
Steps to reproduce the behavior:
<img alt="Nature" src='https://new.rocketlabsqa.ovh/wp-content/rocket-test-data/images/kotł.PNG' >
Expected behavior
Fetchpriority='high' added in image markup and image excluded from LL
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming
The text was updated successfully, but these errors were encountered: