Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear Critical Images on site logo change on pages using it as LCP #6795

Open
DahmaniAdame opened this issue Jul 18, 2024 · 0 comments
Open
Labels
module: OCI Optimize Critical Images priority: high Issues which should be resolved as quickly as possible quick win type: enhancement Improvements that slightly enhance existing functionality and are fast to implement

Comments

@DahmaniAdame
Copy link
Contributor

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version [x]
  • Used the search feature to ensure that the bug hasn’t been reported before [x]

Describe the bug
In some case, the LCP element might be the logo if it's too prominent.

If the logo is changed, and OCI has been already generated, WP Rocket will keep preloading the wrong LCP image.

To Reproduce
Steps to reproduce the behavior:

  1. Make the logo big enough to be the LCP element
  2. Generate OCI
  3. Change the logo
  4. See error

Expected behavior
Though it's not generally expected for the logo to be the LCP element, but it might happen.
We need to track logo changes, at least on the Customizer, and clear rows on OCI where it's being used as the LCP element.

Screenshots
N/A

Additional context
N/A

Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming

@DahmaniAdame DahmaniAdame added lcp type: enhancement Improvements that slightly enhance existing functionality and are fast to implement labels Jul 18, 2024
@piotrbak piotrbak added module: OCI Optimize Critical Images and removed lcp labels Jul 18, 2024
@benorfaz benorfaz added the priority: high Issues which should be resolved as quickly as possible label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: OCI Optimize Critical Images priority: high Issues which should be resolved as quickly as possible quick win type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

No branches or pull requests

3 participants