Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading Issue with Elementor and JSMin #600

Open
martinbkaiser opened this issue Jun 11, 2019 · 0 comments
Open

Loading Issue with Elementor and JSMin #600

martinbkaiser opened this issue Jun 11, 2019 · 0 comments

Comments

@martinbkaiser
Copy link

I think there is a issue with the JSMin:minify(function) and Elementor. It seems to give a PHP error every once in awhile and that seems to stop the page from loading past the header.

[11-Jun-2019 18:08:09 UTC] PHP Fatal error: Uncaught Error: Call to undefined method JSMin::minify() in /www/wp-content/plugins/wp-property/lib/class_functions.php:2568
Stack trace:
#0 /www/wp-content/plugins/wp-property-supermap/static/views/supermap-js.php(313): WPP_F::minify_js('<script type="t...')
#1 /www/wp-content/plugins/wp-property-supermap/lib/class-wpp-supermap.php(1131): include('/www/wp-content...')
#2 /www/wp-content/plugins/wp-property-supermap/lib/class-wpp-supermap.php(950): class_wpp_supermap::supermap_template(Array, Array)
#3 /www/wp-includes/shortcodes.php(325): class_wpp_supermap::shortcode_supermap(Array, '', 'supermap')
#4 [internal function]: do_shortcode_tag(Array)
#5 /www/wp-includes/shortcodes.php(199): preg_replace_callback('/\[(\[?)(superm...', 'do_shortcode_ta...', '[supermap hide_...')
#6 /www/wp-content/plugins/elementor/includes/widgets/shortcode.php(130): do_shortcode('[supermap hide_...')
#7 /www/wp-content/plugins/elementor/includes/base/widget-base.php(501): Elementor\Widget_Shortcode->render()
#8 /www/wp-content in /www/wp-content/plugins/wp-property/lib/class_functions.php on line 2568

To Reproduce
Install Elementor and refresh the page a bunch of times, you will most likely see the page half load at least once.

Desktop (please complete the following information):

  • OS: Windows
  • Browser Chrome
  • Version 74.0.3729.169

For a temporary fix I removed the JSMin::minify function:

wp-property/lib/class_functions.php - Line 2568
Changed:
$data = JSMin::minify($data);
to
$data = $data;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant