New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS error for Select option with number value #805

Open

grappler opened this issue Nov 30, 2018 · 0 comments

Contributor

grappler commented Nov 30, 2018

When using these two configurations I get an JS error in the console: Uncaught TypeError: data.value.split is not a function

[
	'label'   => esc_html__( 'Zoom', 'static-map' ),
	'attr'    => 'zoom',
	'type'    => 'select',
	'options' => range( 1, 22 ),
],
[
	'label'   => esc_html__( 'Zoom', 'static-map' ),
	'attr'    => 'zoom',
	'type'    => 'select',
	'options' => array_combine( range( 0, 22 ), range( 0, 22 ) ),
],

The reason for this is that the data.value has a typeof number instead of string in these cases.

If I change the code to the following it works fine.

[
	'label'   => esc_html__( 'Zoom', 'static-map' ),
	'attr'    => 'zoom',
	'type'    => 'select',
	'options' => array_combine( range( 1, 22 ), range( 1, 22 ) ),
],

Related change #745

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment