extend "File URL Replacement" options

[ewsopp]

• Change options to the following:

• Disable

• Enable Editor

• Enable Meta

• Enable Editor & Meta

• Adjust the description from:

Scans post content and meta during presentation and replaces local media file urls with GCS urls. This setting does not modify your database.

to:

Scans post content and meta during presentation and replaces local media file urls with GCS urls. Depending on the amount of meta, this could be significantly impact performance negatively. This setting does not modify your database.

• ensure that "File URL Replacement" option is disabled by default for new installations.

[alimuzzaman]

@ewsopp
What if user had it enabled, then which one it should get migrated to?
Enable Editor & Meta?

[alimuzzaman]

[ewsopp]

Correct, if they had it Enable previously we will migrate them to the new Enable Editor & Meta option.

[ewsopp]

We need to update the related constant. https://github.com/wpCloud/wp-stateless/wiki/Constants#wp_stateless_media_body_rewrite

• default value: false
• options: editor, meta, or true

True would enable both editor and meta scanning. The other options should explain themselves.

This would allow it work well for people who are already using this setting.

[alimuzzaman]

@ewsopp Options updated.

I think we should add When selecting meta or true to be clear.

Scans post content and meta during presentation and replaces local media file urls with GCS urls. Depending on the amount of meta, this could be significantly impact performance negatively. This setting does not modify your database.

To

Scans post content and meta during presentation and replaces local media file urls with GCS urls. When selecting meta or true depending on the amount of meta, this could be significantly impact performance negatively. This setting does not modify your database.

[antonkorotkov]

I think we should add When selecting meta or true to be clear.

Makes sense

[ewsopp]

Agreed

[antonkorotkov]

@alimuzzaman I think this section should show up for each option from enable group. Right now it only shows up for Editor & Meta.

[ewsopp]

Also - the options should be Disable, Enable Editor, Enable Meta, and Enable Editor & Meta.

In the screenshot above, it is missing the word "Enable".

[antonkorotkov]

@alimuzzaman this one done as well?

[alimuzzaman]

@antonkorotkov Sorry missed it.
Just made a commit.

[renduples]

You will have to re-open this issue
Upgrading from Version 2.1.9 to 2.2.1 - breaks everything
We have tried every setting for File URL Replacement but no joy.
It incorrectly sets the path in the srcset element

[ewsopp]

@renduples what do you mean by "breaks everything." Can you be more specific?

[ewsopp]

I think this may be related to #342. Could you try using the latest version linked to within that issue please?

[renduples]

Correct after upgrading to 2.2.1 srcset no longer reference Google Cloud but rather wp-uploads

[ewsopp]

@renduples the issue with srcset should be resolved with today's v2.2.2 release (see issue #342).

Please upgrade and let us know if you have any more problems. Thank you