Skip to content
This repository has been archived by the owner on Oct 27, 2021. It is now read-only.

UI Improvements #58

Open
bartkerfeld opened this issue Nov 13, 2019 · 0 comments
Open

UI Improvements #58

bartkerfeld opened this issue Nov 13, 2019 · 0 comments

Comments

@bartkerfeld
Copy link

bartkerfeld commented Nov 13, 2019

These are all nits, but some thoughts I had while using the program.

  1. Move Wheel Diameter into feedback section. Having it at the top implies it used in both feedforward and feedback, but in reality, it only affects feedback values.

  2. Have the units entry dynamically change the default values for "Motion Threshold", "Max Acceptable Position Error", "Max Acceptable Velocity Error" to be values you have deemed good in the past. For example, when we did our characterization in meters, we set our Motion Threshold to 0.006096 meters (taken by converting the 0.02 feet shown in the README). This should be done automatically. Additionally, changing the units should also update the labels (e.g. if set to feet, we should get a label Motion Threshold (feet/s)

  3. I don't think the Analyze Data button needs to exists. The data should be analyzed implicitly if anything that affects the analysis has changed (e.g. new file loaded, Motion Threshold changed, etc...). I know I got stuck wondering why the graphs didn't change after I changed the Motion Threshold and it was because I didn't re-analyze.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant