Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online Vendor Dependency Not Working #507

Closed
mdurrani808 opened this issue Dec 29, 2021 · 9 comments · Fixed by #515
Closed

Online Vendor Dependency Not Working #507

mdurrani808 opened this issue Dec 29, 2021 · 9 comments · Fixed by #515

Comments

@mdurrani808
Copy link

To Reproduce:
Create a new Java example project (type does not matter), go to the command pallet, manage vendor libraries, Install vendor libraries (online), and then use this link https://maven.photonvision.org/repository/internal/org/photonvision/PhotonLib-json/1.0/PhotonLib-json-1.0.json. Most of the time, when you click enter, nothing will happen and the .json file does not show up. The expected behavior is a dialogue showing up telling me that I should build and the appropriate .json file will show up.

This has happened on a variety of systems.

Is this a VS Code Extension issue or a link issue?

@ThadHouse
Copy link
Member

Which vscode-wpilib plugin version?

@BrenekH
Copy link

BrenekH commented Dec 29, 2021

Is this perhaps related to #497? I believe the fix is already in the latest beta build.

@mdurrani808
Copy link
Author

Which vscode-wpilib plugin version?

Project Version: 2021.3.1
Extension Version: 2021.1.2

Is this perhaps related to #497? I believe the fix is already in the latest beta build.

I will look into if we use that, I had not seen that before.

@mdurrani808
Copy link
Author

Just checked, we do use Let's Encrypt. Will the fix be in place for the 2022 season?

@ThadHouse
Copy link
Member

Yeah 2022 projects will have a workaround for letsencrypt repos.

@PeterJohnson
Copy link
Member

Closing as duplicate.

@sciencewhiz
Copy link
Contributor

I'm not sure that this is fixed. In beta 4, I get the following:
image

At least it shows an error message now.

@ThadHouse
Copy link
Member

You need to create a new project with beta 4. The fix is in the templates.

@sciencewhiz
Copy link
Contributor

This was with a new project with beta 4, with the fix in settings.json

@PeterJohnson PeterJohnson linked a pull request Jan 10, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants