-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting #33
Linting #33
Conversation
Yes, I think follow the Gatsby style code does not make sense, if the Airbnb style is defined as the standard. Initially, I developed the Lumen-starter based on the gatsby-starter-blog. But if you follow Airbnb Style Guide (https://github.com/airbnb/javascript/tree/master/react), as in this case, then semicolons are needed to avoid errors. |
adds .eslintcache to gitignore
adds react/forbid-prop-types to be ignored in eslintrc could be added in an additional refactoring round right now, I'm not sure what to choose as proptypes...
adds readNext to my-second-post to show this feature in the demo
@WPioneer I finished fixing all linting errors and added some exceptions for rules that would have required more restructuring. IMO this is ready to merge. |
@abisz Great job! Thank you for your contribution! |
I started setting up the linting config and fixed the errors of
html.js
.Before I continue, I wanted to check whether the styling options are approved.
Especially the semicolon option might be controversial, as they aren't used in the gatsby lint options.
IMO it's good practice to write semicolons, but I don't care if you want to stick to the gatsby style.
I'm doing the rest of the files within this pull request, just wanted to check before doing a lot of work.