Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting #33

Merged
merged 13 commits into from
Mar 8, 2017
Merged

Linting #33

merged 13 commits into from
Mar 8, 2017

Conversation

abisz
Copy link
Contributor

@abisz abisz commented Mar 7, 2017

I started setting up the linting config and fixed the errors of html.js.

Before I continue, I wanted to check whether the styling options are approved.
Especially the semicolon option might be controversial, as they aren't used in the gatsby lint options.

IMO it's good practice to write semicolons, but I don't care if you want to stick to the gatsby style.

I'm doing the rest of the files within this pull request, just wanted to check before doing a lot of work.

@alxshelepenok
Copy link
Owner

Before I continue, I wanted to check whether the styling options are approved.

Yes, I think follow the Gatsby style code does not make sense, if the Airbnb style is defined as the standard.

Initially, I developed the Lumen-starter based on the gatsby-starter-blog.
In the gatsby-starter-blog did not have semicolons, therefore in the Lumen-starter there are none.

But if you follow Airbnb Style Guide (https://github.com/airbnb/javascript/tree/master/react), as in this case, then semicolons are needed to avoid errors.

@abisz
Copy link
Contributor Author

abisz commented Mar 8, 2017

@WPioneer I finished fixing all linting errors and added some exceptions for rules that would have required more restructuring. IMO this is ready to merge.

@alxshelepenok
Copy link
Owner

@abisz Great job! Thank you for your contribution!

@alxshelepenok alxshelepenok merged commit c8e68a2 into alxshelepenok:master Mar 8, 2017
@alxshelepenok alxshelepenok mentioned this pull request Mar 8, 2017
@abisz abisz deleted the linting branch March 9, 2017 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants