Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPPCOnnect fails without setting headless either true or new #2079

Closed
ejike-nnodi opened this issue Mar 3, 2024 · 1 comment
Closed

WPPCOnnect fails without setting headless either true or new #2079

ejike-nnodi opened this issue Mar 3, 2024 · 1 comment
Labels
enhancement New feature or request needs triage

Comments

@ejike-nnodi
Copy link

Is your feature request related to a problem? Please describe.
While i was testing today i noticed that puppeteer-core wasn't starting, so i played a little bit with the headless parameter, i noticed that false doesnt work anymore. I think its related to the warning:


    In the near future `headless: true` will default to the new Headless mode
    for Chrome instead of the old Headless implementation. For more
    information, please see https://developer.chrome.com/articles/new-headless/.
    Consider opting in early by passing `headless: "new"` to `puppeteer.launch()`
    If you encounter any bugs, please report them to https://github.com/puppeteer/puppeteer/issues/new/choose.

and the article
https://developer.chrome.com/docs/chromium/new-headless

Describe the solution you'd like
I think we should set the parameter as new as default, or let users know in the documentation
I am not familiar with NodeJs, im not sure where that can be added.

Food for Thought

@ejike-nnodi ejike-nnodi added enhancement New feature or request needs triage labels Mar 3, 2024
@icleitoncosta
Copy link
Contributor

Hello, thank you for letting me know, I will run some tests later. I was waiting for new Chrome updates; unfortunately, in the new headless mode, Debian versions were failing to work, so I preferred to postpone this change for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage
Projects
None yet
Development

No branches or pull requests

2 participants