Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear Cache on Multisite w/ Sub-Directories Not Working #39

Closed
raamdev opened this issue Dec 20, 2013 · 15 comments
Closed

Clear Cache on Multisite w/ Sub-Directories Not Working #39

raamdev opened this issue Dec 20, 2013 · 15 comments
Labels

Comments

@raamdev
Copy link
Contributor

raamdev commented Dec 20, 2013

@SBOQ writes in #25:

I have 2 Multisite test environments. One is with the subdomains and the other with subfolders. The first one (subdomains) works perfectly, but the other one (subfolders) has the problems as described in this thread by @mrkeyboard, i.e. deleting the cache for individual site doesn't work on the Multisite subfolder installation. It will clear the cache for the individual page/post if it gets updated, including the Home & Posts page purging. But it won't work when I hit the clear cache button, the same message appears as @mrkeyboard explained with the screenshot.

Update: I've tested this with all other plugins deactivated but it still didn't work.
Deleting the cache for individual site doesn't work on the Multisite subfolder installation.

@SBOQ Can you tell me where you're activating Quick Cache in your multisite environment? Are you Network Activating it from the Network Admin? When you're trying to clear the cache on a child site, are you doing this while logged in as a Super Admin? Any screenshots or further information you can you provide would be greatly appreciated.

@Slobork
Copy link

Slobork commented Dec 21, 2013

@raamdev I am activating the QC Network wide.
I'm clearing the cache as a Super Admin. Currently I do not have other users on this installation.
Regarding the screenshot it's the same thing as one of the users reported in the issue #25.

@jaswrks
Copy link

jaswrks commented Dec 21, 2013

@raamdev I believe this issue has already been solved by 9bfe5ca
It's just not in the official release yet.

@jaswrks
Copy link

jaswrks commented Dec 21, 2013

@raamdev There is a pending pull request against the Quick-Cache-Pro repo that needs to be merged also.
wpsharks/comet-cache-pro#4

@raamdev
Copy link
Contributor Author

raamdev commented Dec 23, 2013

@JasWSInc I tested 9bfe5ca in Quick Cache Pro against a site running Multisite with sub-folders and clicking "Clear Cache" from the admin bar while on the Dashboard for a Child Site clears the entire cache, for all sites, not just for that Child Site.

It seems that @SBOQ has tested Quick Cache running in a Multisite environment with sub-domains and it sounds like clicking "Clear Cache" while on the Dashboard for a Child Site is clearing that individual site's cache (the behavior I'd expect in both cases).

I haven't tested Multisite running with sub-domains yet, but I'll be setting up a test environment shortly to confirm the current behavior.

@raamdev
Copy link
Contributor Author

raamdev commented Dec 23, 2013

@JasWSInc I have confirmed the behavior that I explained in my previous comment with sub-domain multisite installs: When pressing "Clear Cache" on the Admin Bar from the Dashboard of a Child Site, only that child site's cache is cleared (expected behavior).

When doing the same thing from the Dashboard on a Child Site under a sub-directory install, the entire cache is deleted, for all sites, including the parent site (unexpected behavior).

@jaswrks
Copy link

jaswrks commented Dec 24, 2013

@raamdev Roger that. I'll take another look at this.

@jaswrks
Copy link

jaswrks commented Dec 24, 2013

When doing the same thing from the Dashboard on a Child Site under a sub-directory install, the entire cache is deleted, for all sites, including the parent site (unexpected behavior).

@raamdev I just tested the latest development copy (with all pull requests merged in) and I was unable to reproduce this on a sub-directory install (e.g. it's working as expected; clearing only the cache for the current blog you're on). I'm running a sub-directory install with this URL formation.

http://www.example.com/
http://www.example.com/blog1/
http://www.example.com/blog2/
http://www.example.com/blog3/

I'm going to test the following formation next to see if I can reproduce it this way.

http://www.example.com/sub-directory/
http://www.example.com/sub-directory/blog1/
http://www.example.com/sub-directory/blog2/
http://www.example.com/sub-directory/blog3/

@jaswrks
Copy link

jaswrks commented Dec 24, 2013

@raamdev I reproduced it under this directory structure. Taking a look now.

http://www.example.com/sub-directory/
http://www.example.com/sub-directory/blog1/
http://www.example.com/sub-directory/blog2/
http://www.example.com/sub-directory/blog3/

@jaswrks
Copy link

jaswrks commented Dec 24, 2013

@raamdev Issue identified. I'll commit a fix shortly.

@jaswrks
Copy link

jaswrks commented Dec 24, 2013

@raamdev These latest commits are now pending your approval in the existing pull requests for both Quick Cache and Quick Cache Pro. The two commits referenced above will correct the bug reported in this issue.

https://github.com/JasWSInc/Quick-Cache/commit/d2f9697b58242e9593cfac5cd0acd10bd178c8ab
https://github.com/JasWSInc/Quick-Cache-Pro/commit/98329d66063bfbbacfcd33af7fd5e637039502f0

How to confirm this bug is fixed.

  • Update to the latest dev version of Quick Cache Pro (with all pull requests merged in).
  • Save your Quick Cache Options once after this update. This forces Quick Cache to rebuild it's map of blog paths in /wp-content/cache/qc-blog-paths. Note: this step is only required during testing, this map is automatically rebuilt whenever a site owner updates to the latest version of Quick Cache or Quick Cache Pro (e.g. when the version changes).
  • Test on both of these URL formations please.
http://www.example.com/
http://www.example.com/blog1/
http://www.example.com/blog2/
http://www.example.com/blog3/
http://www.example.com/sub-directory/
http://www.example.com/sub-directory/blog1/
http://www.example.com/sub-directory/blog2/
http://www.example.com/sub-directory/blog3/

I can confirm this now works as expected in all cases; e.g. for sub-domains, sub-directories, and also for nested sub-directories (at any depth).

@raamdev
Copy link
Contributor Author

raamdev commented Dec 24, 2013

Thank you, @JasWSInc. I have tested your commits against the following multisite environments and I can confirm clearing the cache now works as expected:

Sub-directories

http://www.example.com/
http://www.example.com/blog1/
http://www.example.com/blog2/
http://www.example.com/blog3/
http://www.example.com/sub-directory/
http://www.example.com/sub-directory/blog1/
http://www.example.com/sub-directory/blog2/
http://www.example.com/sub-directory/blog3/

Sub-domains

http://www.example.com/
http://blog1.example.com/
http://blog2.example.com/
http://blog3..example.com/

@raamdev
Copy link
Contributor Author

raamdev commented Dec 25, 2013

This bug was fixed in Quick Cache v131224:

https://github.com/WebSharks/Quick-Cache/releases/tag/131224

@raamdev raamdev closed this as completed Dec 25, 2013
@jaswrks
Copy link

jaswrks commented Dec 25, 2013

Awesome! Thanks for the merge.

@jaswrks jaswrks mentioned this issue Dec 26, 2013
15 tasks
@her63
Copy link

her63 commented Jan 30, 2014

I am herry , Admin of www.kristusrajaandalas.or.id could you tell me what is MD5 version salt and how to do it. thank u

@raamdev
Copy link
Contributor Author

raamdev commented Feb 3, 2014

@her63 Please open a trouble ticket here: WebSharks Support Center

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants