Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashicons icon gets overridden on login screen #1187

Closed
Beee4life opened this issue Apr 22, 2020 · 2 comments
Closed

Dashicons icon gets overridden on login screen #1187

Beee4life opened this issue Apr 22, 2020 · 2 comments

Comments

@Beee4life
Copy link

EXPLANATION OF THE ISSUE

Dashicons font is overridden on the login page because of an !important, in inline css, generated by user settings and thus shown as a tofu.

Screenshot 2020-04-22 at 15 03 20

STEPS TO REPRODUCE THE ISSUE

Install the plugin.
Go to General Options > Login/Registration design.
Save it.
Check login screen.

BEHAVIOR THAT I EXPECTED

That the 'eye' dashicon would show in the right side of the password field.

BEHAVIOR THAT I OBSERVED

It gets overridden.

PROPOSED SOLUTION

Remove the important $i from line 110 in src/includes/classes/login-customizations.inc.php

NOTE

This only happens after saving the user settings. If not saved, default settings are used, which do not have this (css) line.

@Beee4life
Copy link
Author

I just found out this value can be changed with a filter, see info here.

add_filter('ws_plugin__s2member_login_header_styles_important', '__return_null');

@clavaque
Copy link
Contributor

I added a new rule in s2 to give importance to the dashicons font. c53be4d

This seems to be an issue that almost everyone will have, so I wanted to avoid it without needing a customization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants