Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix attempt for https://github.com/wq/django-natural-keys/issues/8 #10

Merged
merged 1 commit into from Mar 1, 2019

Conversation

marcosox
Copy link
Contributor

@marcosox marcosox commented Jul 31, 2018

This should fix #8 by running the function only when its argument is a string (and thus a natural key slug)

@marcosox
Copy link
Contributor Author

marcosox commented Aug 1, 2018

Please note I am not a maintainer of this project, I just found this library and just started to use it.

I updated the patch. I'd like to know your opinion on it, since I'm not that experienced as a python programmer.

@marcosox
Copy link
Contributor Author

marcosox commented Aug 1, 2018

I don't know why travis is running the tests against the old commit (c8aecc6) instead of the new one (2ab32b4). I run them locally and they all pass.

@marcosox
Copy link
Contributor Author

@sheppard do you have any idea about why travis is complaining in #10 and #11 ? Can you merge the pull requests?

@sheppard
Copy link
Member

sheppard commented Mar 1, 2019

Thanks, I finally merged this. After rebasing and fixing conflicts with #9 (and #11), the main effect of this merge is the str check. There is a small chance that a valid slug might be something other than a str (such as a Python2 unicode instance). But we can wait to see if that even comes up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'Q' object has no attribute 'split'
2 participants