Require Django version < 2.0 for now (otherwise tests fail) #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error with Django 2.0:
File ".../wq.db/.eggs/python_social_auth-0.2.21-py3.4.egg/social/apps/django_app/default/models.py", line 33, in AbstractUserSocialAuth
user = models.ForeignKey(USER_MODEL, related_name='social_auth')
TypeError: __init__() missing 1 required positional argument: 'on_delete'
sheppard
force-pushed
the
forbid_django_2
branch
from
43065fc
to
483e7db
Compare
|
Thanks, the travis issue was unrelated. I released v1.0.0-1 to PyPI and created #72. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error with Django 2.0:
File ".../wq.db/.eggs/python_social_auth-0.2.21-py3.4.egg/social/apps/django_app/default/models.py", line 33, in AbstractUserSocialAuth
user = models.ForeignKey(USER_MODEL, related_name='social_auth')
TypeError: init() missing 1 required positional argument: 'on_delete'