Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Ci with github actions #15

Closed
OlivierLDff opened this issue Jul 9, 2020 · 2 comments
Closed

Adding Ci with github actions #15

OlivierLDff opened this issue Jul 9, 2020 · 2 comments

Comments

@OlivierLDff
Copy link
Contributor

I'm adding ci with GH actions with lots of my small project because it's so easy to do.
I tried to add it to eventpp on a branch on my repo. https://github.com/OlivierLDff/eventpp/actions
As you can see tests are not compiling on macOs.

Would you be interested in such a PR? I can also fix compilation error on mac when i will have time.
I think it can be cool to have at least CI for windows/ubuntu in Release
@wqking
Copy link
Owner

wqking commented Jul 9, 2020

Yes, go ahead. It would be great to have CI integrated.
I can't fix issues for MacOS because I don't have any Mac machines nor virtual environments.

@OlivierLDff
Copy link
Contributor Author

I created a PR with windows and ubuntu which work. I will push later for mac with fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wqking @OlivierLDff