Small bug fixes #19
Merged
Small bug fixes #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the following bugs: 1. If we have multiple controls on the same activity, with different texts, whenever the activity is recreated(on rotation for example), all the controls take the same text 2. When we have multiple controls on the same activity, and set texts to each one programmatically, all hint text views have an alpha of 1 - only the currently selected one should have alpha = 1, the rest should have alpha = 0.33
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is the first time I have done this so please excuse any mistakes I may have made. I used your library for a school project and I noticed and fixed a couple of bugs:
This was fixed by giving each editText an unique id. The method that generates the ids is in a different class but I suppose it can be moved as a private static method if you prefer so.
I edited the files using the browser so I hope that there aren't any mistakes in the commits.