Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite TimeService PMD rule #71

Open
pavelhoral opened this issue Jan 23, 2023 · 0 comments
Open

Rewrite TimeService PMD rule #71

pavelhoral opened this issue Jan 23, 2023 · 0 comments

Comments

@pavelhoral
Copy link
Member

pavelhoral commented Jan 23, 2023 •
edited
Loading

We don't have source code for the org.forgerock.openam.pmd.rules:enforce-timeservice. Should be fairly straightforward to create that rule from scratch (I hope) as XPath rule. Until then we might disable PMD by default.

TimeService was introduced to allow customizable time source. So any direct call to stuff like Date constructor or System.currentTimeMillis is probably incorrect. Exact set of rules can be probably inferred from commits that introduced TimeService.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pavelhoral