Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display text in the editor based on the published appearance setting #15

Closed
AngeloStavrow opened this issue Aug 20, 2020 · 1 comment · Fixed by #58
Closed

Display text in the editor based on the published appearance setting #15

AngeloStavrow opened this issue Aug 20, 2020 · 1 comment · Fixed by #58
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@AngeloStavrow
Copy link
Collaborator

AngeloStavrow commented Aug 20, 2020

This is a stretch goal for an extension of #14, which only sets what font the Post will use after publishing. It'd be nice to show this change in the PostEditorView as well.

@AngeloStavrow AngeloStavrow added the enhancement New feature or request label Aug 20, 2020
@thebaer
Copy link
Member

thebaer commented Aug 28, 2020

As mentioned on our call, I think this is crucial for the 1.0 beta -- users will want to see the same fonts they're used to on the web. A minimum implementation might be:

  • Use our "serif" font (Lora) for editor text on all local drafts (since this is the setting they publish with)
  • For remote Posts, set the editor text font according to its appearance property

Beyond that, we can allow the user to set the post appearance, as outlined in #14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

2 participants