Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always initialize database after --config #126

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Conversation

thebaer
Copy link
Member

@thebaer thebaer commented Jun 20, 2019

Always initialize database after --config

Previously, this would only run when configuring an instance for single-user usage. Now it'll also run when configuring for multi-user usage.

It also adds a log when the database has already been initialized.


Previous PR description:

This improves the interactive configuration process that runs with the --config flag present -- particularly to support our work on a DigitalOcean one-click install image (T600).

Previously, this would only run when configuring an instance for
single-user usage. Now it'll also run when configuring for multi-user
usage.

It also adds a log when the database has already been initialized.
@thebaer thebaer added this to the 0.10 milestone Jun 20, 2019
@thebaer thebaer marked this pull request as ready for review June 23, 2019 20:02
@thebaer
Copy link
Member Author

thebaer commented Jun 23, 2019

The second part of this is addressed in #127. So this PR is ready for review.

@thebaer thebaer requested a review from a user June 23, 2019 20:03
@thebaer thebaer changed the title Improve interactive config process for automated environments Always initialize database after --config Jun 23, 2019
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't test but otherwise 👍

@thebaer
Copy link
Member Author

thebaer commented Jun 27, 2019

Thanks for taking a look! Merging now.

@thebaer thebaer merged commit bb0be02 into develop Jun 27, 2019
@thebaer thebaer deleted the config-improvements branch June 27, 2019 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant