Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get versioninfo from the git repository #32

Merged
merged 2 commits into from
Nov 20, 2018
Merged

Get versioninfo from the git repository #32

merged 2 commits into from
Nov 20, 2018

Conversation

mrvdb
Copy link
Collaborator

@mrvdb mrvdb commented Nov 20, 2018

Sets value of softwareVer during build

@mrvdb
Get versioninfo from the git repository
c25d0be 
Sets value of softwareVer during build
thebaer
thebaer requested changes Nov 20, 2018
View reviewed changes
Copy link
Member

@thebaer thebaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is really useful! (And something I didn't know was possible.) I just have two minor suggestions before merging this.

Makefile Outdated Show resolved Hide resolved
app.go Outdated Show resolved Hide resolved
app.go Outdated Show resolved Hide resolved
@mrvdb
Don't automatically include "v" from git
b030921 
- "v" should not be part of the version (softwareVer variable is used
  in other places)
- formatting
@thebaer
Copy link
Member

thebaer commented Nov 20, 2018

Looks great, thanks!

@thebaer thebaer merged commit a4751c7 into writefreely:master Nov 20, 2018
@mrvdb
Copy link
Collaborator Author

mrvdb commented Nov 20, 2018

whoohoo!

@thebaer thebaer added this to the 0.4 milestone Nov 20, 2018
thebaer
thebaer reviewed Nov 21, 2018
View reviewed changes
Copy link
Member

@thebaer thebaer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing the review.

...Or apparently I can't now that this is merged.

@thebaer thebaer requested review from thebaer and removed request for thebaer November 21, 2018 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebaer thebaer thebaer requested changes

Assignees
No one assigned
Labels
enhancement
Milestone
0.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrvdb @thebaer