Version number and healthcheck fixes for Docker image #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
claabs
commented
Feb 6, 2024
•
claabs
commented
- Include .git context in Docker build for UI version number
- Fixes Version not available in Docker image #873
- Potential caching/performance impact, but it's a really simple solution that doesn't require any special scripting that would break local Docker Compose dev usage and whatnot.
- I have signed the CLA
|
Thanks for fixing this, and bringing up the healthcheck issue! Just as an FYI, we prefer each PR to address only one issue at a time. Like in this case, it seems the healthcheck issue was also addressed in a different way in #875. I'm fine with either solution, but for this PR, could you remove the changes in 9e14b5f and then either open an individual PR for it, or let us know if you think #875 is a fine solution for the problem. With that sorted out, we can get this merged! |
|
Trimmed this PR to only the one fix. Opened #894. Up to the maintainers which healthcheck fix they want to use. I take no offense either way. |
|
Awesome, thanks! |
thebaer
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.