Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core.less: Use a bigger font size for h2 #315

Closed
wants to merge 1 commit into from

Conversation

@RJ722
Copy link
Contributor

@RJ722 RJ722 commented May 25, 2020

The font-size for h2 was set to be 1.17em, which is also the font size defined for h3 by user agent stylesheet. This lead to both h2 and h3 being rendered in same size. Use 1.2em for h2.

Closes: #217


  • I have signed the CLA
The font-size for h2 was set to be 1.17em, which is also the font
size defined for h3 by user agent stylesheet. This lead to both
h2 and h3 being rendered in same size. Use 1.2em for h2.

Closes: #217
@thebaer
Copy link
Member

@thebaer thebaer commented Jun 8, 2020

Thanks for contributing this, @RJ722! I'll test and verify this fix soon. Otherwise, anyone else should feel free to weigh in!

Copy link
Member

@thebaer thebaer left a comment

I think we should actually go with 1.4em, to make it consistent with the h2 font size from the blog home page:

writefreely/less/core.less

Lines 659 to 664 in 53cb5c3

body#collection article, body#subpage article {
padding-top: 0;
padding-bottom: 0;
.book {
h2 {
font-size: 1.4em;

@thebaer thebaer added this to the 0.13 milestone Jul 23, 2020
@thebaer thebaer mentioned this pull request Aug 13, 2020
1 of 1 task complete
@thebaer
Copy link
Member

@thebaer thebaer commented Aug 13, 2020

Making these revisions in #368.

@thebaer thebaer closed this Aug 13, 2020
@thebaer thebaer removed this from the 0.13 milestone Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.