Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config bind address #5

Closed
koehn opened this issue Nov 10, 2018 · 8 comments
Closed

Config bind address #5

koehn opened this issue Nov 10, 2018 · 8 comments
Assignees

Comments

@koehn
Copy link
Collaborator

koehn commented Nov 10, 2018

I'm running writefreely in a Docker container and I'd like it to bind to other than localhost:8080 (preferably 0.0.0.0:8080) so I can forward connections into it from my web server. How can I configure this?

@koehn
Copy link
Collaborator Author

koehn commented Nov 10, 2018

never mid; it doesn't actually bind to localhost.

@koehn koehn closed this as completed Nov 10, 2018
@jlelse
Copy link

jlelse commented Nov 13, 2018

Could you share your Dockerfile?

@Fastidious
Copy link

@koehn would love to have such dockerfile too. Thanks!

@koehn
Copy link
Collaborator Author

koehn commented Nov 13, 2018

You can grab a copy of the Dockerfile I use from my GitLab project. I publish it on Docker Hub at koehn/writefreely.

If the builders of Writefreely want to include it in their Git repo, they're welcome to do so. It's licensed under the AGPL.

@thebaer
Copy link
Member

thebaer commented Nov 13, 2018

Thanks @koehn! We are working on an official Docker image too: https://phabricator.write.as/T531

@mrvdb
Copy link
Collaborator

mrvdb commented Nov 22, 2018

Am I missing something? How can writefreely be bound to 127.0.0.1 only for example when running behind nginx? (was about to open new issue when I saw this one)

@mrvdb
Copy link
Collaborator

mrvdb commented Nov 26, 2018

Reopening because I think this is still unresolved, please correct me if I'm missing something here.

Current situation:

  • log says 'localhost' while it does not actually bind to localhost
  • binding by default to 0.0.0.0 (or ipv6 equiv in dual stack) is perhaps not the best choice

What I personally would like:

  1. make the log say what it actually does
  2. change the default to actually bind to localhost , or even better 127.0.0.1 / [::1]
  3. add support for explicit binding (not sure how net/http interprets this, seems to be just an IP string)

@mrvdb
Copy link
Collaborator

mrvdb commented Nov 28, 2018

Merged in fb18b8f

@mrvdb mrvdb closed this as completed Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants