Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No version when default metrics disabled #274

Merged
merged 2 commits into from
Jun 30, 2019

Conversation

samsk
Copy link

@samsk samsk commented May 10, 2019

Quick fix, to disable collection of static_version if default metrics are disabled.
It throws an error, when connected to multiple databases on same server:

# curl localhost:19201/metrics
An error has occurred while serving metrics:

collected metric "pg_static" { label:<name:"server" value:"172.16.110.20:5432" > label:<name:"short_version" value:"11.2.0" > label:<name:"version" value:"PostgreSQL 11.2 on x86_64-pc-linux-gnu, compiled by gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-36), 64-bit" > untyped:<value:1 > } was collected before with the same name and label values

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 61.932% when pulling a2455bb on samsk:master into c9dc7a2 on wrouesnel:master.

@wrouesnel wrouesnel merged commit 0d4af2b into prometheus-community:master Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants