Build in Docker #333
Closed
Build in Docker #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why wouldn't this be the default approach, definitely should be merged. |
|
We're now using the Prometheus build system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I develop on a Mac, and when I tried to build a docker image using the method in the README it naturally failed because it was trying to run a darwin binary on the linux docker image.
This PR runs the Go build within Docker, which means I can build on my Mac. It also means that the version of Go used is consistent across builds as it's specified in the Dockerfile.
I haven't tried to change the CI build, so this PR is not complete, but I thought I'd submit it in case it was of interest.