Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for secrets files #70

Merged
merged 12 commits into from
Sep 20, 2017

Conversation

matthias-kloeckner
Copy link
Contributor

this introduces new env variables for user name, password and uri. more importantly user name and password can also be read from files - this is needed to securely pass secrets to the docker container by just mounting these files.

new variables:
DATA_SOURCE_USER
DATA_SOURCE_USER_FILE
DATA_SOURCE_PASS
DATA_SOURCE_PASS_FILE
DATA_SOURCE_URI

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 49.605% when pulling fe42532 on matthias-kloeckner:master into c4f701e on wrouesnel:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 49.605% when pulling fe42532 on matthias-kloeckner:master into c4f701e on wrouesnel:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 49.605% when pulling b302718 on matthias-kloeckner:master into 1fa394d on wrouesnel:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.1%) to 48.694% when pulling 8a7daeb on matthias-kloeckner:master into 81194c9 on wrouesnel:master.

Copy link
Contributor

@wrouesnel wrouesnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a sufficient change that we really need an explicit test case which proves the "win" conditions.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.1%) to 48.694% when pulling ac60ce9 on matthias-kloeckner:master into 1afbd62 on wrouesnel:master.

@hartmut-pq
Copy link

+1 would like to see secrets supported, too!

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.0%) to 48.844% when pulling abc018e on matthias-kloeckner:master into 1afbd62 on wrouesnel:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.0%) to 48.844% when pulling 551af02 on matthias-kloeckner:master into 1afbd62 on wrouesnel:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.0%) to 48.844% when pulling 97518a2 on matthias-kloeckner:master into 1afbd62 on wrouesnel:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.0%) to 48.844% when pulling 9328047 on matthias-kloeckner:master into 1afbd62 on wrouesnel:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.0%) to 48.844% when pulling c3ff253 on matthias-kloeckner:master into 1afbd62 on wrouesnel:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 52.388% when pulling 908912d on matthias-kloeckner:master into 1afbd62 on wrouesnel:master.

@matthias-kloeckner
Copy link
Contributor Author

added some tests and fixed the makefile. sorry for the amount of commits - I needed some test runs on travis to understand the real problem.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.8%) to 54.135% when pulling 05f70bb on matthias-kloeckner:master into e701b80 on wrouesnel:master.

@matthias-kloeckner
Copy link
Contributor Author

@wrouesnel
anything still missing here?

@wrouesnel
Copy link
Contributor

No this is looking good. I'll give it a closer inspection tonight and merge it hopefully.

@wrouesnel wrouesnel merged commit 6e3d130 into prometheus-community:master Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants