-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for secrets files #70
add support for secrets files #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a sufficient change that we really need an explicit test case which proves the "win" conditions.
+1 would like to see secrets supported, too! |
added some tests and fixed the makefile. sorry for the amount of commits - I needed some test runs on travis to understand the real problem. |
@wrouesnel |
No this is looking good. I'll give it a closer inspection tonight and merge it hopefully. |
this introduces new env variables for user name, password and uri. more importantly user name and password can also be read from files - this is needed to securely pass secrets to the docker container by just mounting these files.
new variables:
DATA_SOURCE_USER
DATA_SOURCE_USER_FILE
DATA_SOURCE_PASS
DATA_SOURCE_PASS_FILE
DATA_SOURCE_URI