-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port for Firefox? #4
Comments
Skimming the code, I don't see anything that'd even be affected by MV2 vs. MV3 changes. |
🙏 |
I believe that apart from a couple of manifest file changes the code itself works without alteration as Firefox should support all chrome.* APIs I managed to get it to work by implementing this manifest file for the firefox version |
In Manifest V2 the web_accessible_resources tag must recieve an array containing the resources while in Manifest V3 it should be an array of objects MDN Web Docs |
@helloimbernardo Great work. Currently its loaded in the temporary position for firefox, right now it displays this:
|
I edited my fork to work with Firefox by default and removing that issue (I wrongly assumed I needed to include the ID in the Manifest). Should work by default :) |
Hi! Great work, can you please make a PR and I'll get it merged later today and write up instructions/docs? |
Thanks to @helloimbernardo for doing the initial work with manifest v2. Closing because we have submitted to the firefox store and a firefox release is on the releases page. We may/may not write manual installation instructions depending on how long firefox takes to approve. The issue below has all the relevant info I will be closing this issue now. |
Related issue: #3
Create a compatible version for Firefox (Manifest v2)
Context: https://twitter.com/Techman0/status/1590748545904410624#m
The text was updated successfully, but these errors were encountered: