Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port for Firefox? #4

Closed
maxxcrawford opened this issue Nov 10, 2022 · 8 comments
Closed

Port for Firefox? #4

maxxcrawford opened this issue Nov 10, 2022 · 8 comments

Comments

@maxxcrawford
Copy link

Related issue: #3

Create a compatible version for Firefox (Manifest v2)

Context: https://twitter.com/Techman0/status/1590748545904410624#m

@leo60228
Copy link

Skimming the code, I don't see anything that'd even be affected by MV2 vs. MV3 changes.

@the-jame
Copy link

🙏

@helloimbernardo
Copy link

helloimbernardo commented Nov 10, 2022

I believe that apart from a couple of manifest file changes the code itself works without alteration as Firefox should support all chrome.* APIs

I managed to get it to work by implementing this manifest file for the firefox version

@helloimbernardo
Copy link

In Manifest V2 the web_accessible_resources tag must recieve an array containing the resources while in Manifest V3 it should be an array of objects MDN Web Docs

@mazercore
Copy link

mazercore commented Nov 10, 2022

@helloimbernardo Great work. Currently its loaded in the temporary position for firefox, right now it displays this:

Reading manifest: Warning processing id: An unexpected property was found in the WebExtension manifest.

but otherwise it does work!
image

@helloimbernardo
Copy link

I edited my fork to work with Firefox by default and removing that issue (I wrongly assumed I needed to include the ID in the Manifest). Should work by default :)

@wseagar
Copy link
Owner

wseagar commented Nov 10, 2022

I edited my fork to work with Firefox by default and removing that issue (I wrongly assumed I needed to include the ID in the Manifest). Should work by default :)

Hi! Great work, can you please make a PR and I'll get it merged later today and write up instructions/docs?

@wseagar
Copy link
Owner

wseagar commented Nov 10, 2022

Thanks to @helloimbernardo for doing the initial work with manifest v2. Closing because we have submitted to the firefox store and a firefox release is on the releases page. We may/may not write manual installation instructions depending on how long firefox takes to approve. The issue below has all the relevant info I will be closing this issue now.

#13

@wseagar wseagar closed this as completed Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants