Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issue with 115 #140

Closed
thisisbenwoo opened this issue Jun 14, 2023 · 9 comments
Closed

Compatibility issue with 115 #140

thisisbenwoo opened this issue Jun 14, 2023 · 9 comments

Comments

@thisisbenwoo
Copy link

thisisbenwoo commented Jun 14, 2023

Hi,

I actually use Betterbird, although I don't think this is a Betterbird issue, but Thunderbird. I've upgraded to the beta version of Thunderbird 115. When I type Ctrl-K to do a search, if I type the letter A (lower or upper case), it automatically thinks I'm wanting to Reply-All. So, in reality, I can't search on anything else that has the letter A (or in fact anything that would trigger some sort of message related action).

I've tried using A, C, E, F, I, J, K, M, R (For me, these are mapped to reflect the G-mail keys, so respectively, Reply All, Compose, Archive, Forward, Mark Read, Next, Previous, Mark Read (this is a standard Thunderbird shortcut), and Reply)

I know that 115 is still in beta, but as I test things I thought I'd drop them in here. Also, I'm not sure if this is a TBkeys things or a Thunderbird 115 thing, but the fact that only keys mapped by TBkeys suggests that it is likely related to TBkeys.

UPDATE1: It seems that if I type using Shift and one of the keys above that it does work, but, not if I search using the Caps Lock key.
UPDATE2: It seems like UPDATE1 is true except for A and R

Thanks.

b

@wshanks
Copy link
Owner

wshanks commented Jun 14, 2023

Yes, this is issue #131 which was fixed with #139. If possible, could you zip up the contents of the addon/ directory as a .xpi file and see if it works for you?

I have not had time to test on beta much myself. Perhaps you could answer the question I asked here which was if with this fix for the search bar tbkeys works well enough that we should release a new version marked as compatible with 115 or if more compatibility work is needed first.

@thisisbenwoo
Copy link
Author

@wshanks,
I'd be happy to, but do not know how to? I'm on Windows, I poked around the \Program Files\Betterbird directory then I poked around \Users\me\appdata\Roaming (and Local)\Thunderbird, and don't see a directory called addon. I'm also unfamiliar with what you mean by zip up the contents as a .xpi file.
I'll go to the question in the link and get back to you.

@thisisbenwoo
Copy link
Author

@wshanks Sorry for the break, getting back to this tomorrow, re: your question here, the short answer is no, but I'll give you a more indepth answer tomorrow.

@ChauhanT
Copy link

I can confirm this also happens for other fields (like quick-filter).

@wshanks
Copy link
Owner

wshanks commented Jul 12, 2023

Feel free to mention anything else besides quick-filter. The search box at least should be fixed now.

@wshanks
Copy link
Owner

wshanks commented Jul 20, 2023

The quick filter box was fixed in 2.2.4 (in review queue on addons.thunderbird.net now for tbkeys-lite and released here for plain tbkeys). I will close this for now, but open another issue if you notice another text box capturing keys.

@wshanks wshanks closed this as completed Jul 20, 2023
@ChauhanT
Copy link

Hi @wshanks , thank you for looking into this so quickly! Can't wait for tbkeys-lite to become available on the addons website. Is there any chance you could update this thread when it gets approved ?

@wshanks
Copy link
Owner

wshanks commented Jul 21, 2023

@ChauhanT It should be available now.

@ChauhanT
Copy link

@wshanks Thank you very much for the update and for the info! TB115 feels like it should now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants