Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/usr/share/wslu/conf should be /etc/wslu/conf #241

Closed
tranzystorekk opened this issue Aug 28, 2022 · 3 comments
Closed

/usr/share/wslu/conf should be /etc/wslu/conf #241

tranzystorekk opened this issue Aug 28, 2022 · 3 comments
Labels
Enhancement This is either an issue that describes ehcmnt./feature or a PR that introduces ehcmnt./feature Status: Patched This is fixed and is part of a released version. Target: 4.x This is targeted to the 4.x release.
Milestone

Comments

@tranzystorekk
Copy link
Contributor

The typical location for the global package config files is /etc/...,
From a package maintainer standpoint it feels weird to be installing the conf file to /usr/share/wslu/.

Also the conf file has a screaming "DO NOT EDIT" warning, but I can't see the reasoning? Usually the /etc/ config files for linux packages have root as owner, but that doesn't mean they can't be changed ever, only that it's an operation reserved for system administrators (or copied over to user-specific locations ofc).

@patrick330602
Copy link
Member

patrick330602 commented Aug 28, 2022

Thank you for the feedback, I do see your point, however:

  1. Change the location will break the existing installation (there are people who use the packages since canary versions);
  2. several default settings are stored in this file so I am not expecting users to edit this file.

So in this case, what I can do is this:

  1. Offer file in both locations; and
  2. remove the DO NOT EDIT lines in the /etc one.

However, due to the things pile up in my daily job, I try to get it in 4.0.1 in the coming weeks. Hope you could understand.

@patrick330602 patrick330602 added Enhancement This is either an issue that describes ehcmnt./feature or a PR that introduces ehcmnt./feature Target: 4.x This is targeted to the 4.x release. labels Aug 28, 2022
@patrick330602 patrick330602 added this to the 4.0.1 milestone Aug 28, 2022
@tranzystorekk
Copy link
Contributor Author

tranzystorekk commented Aug 28, 2022

Thanks for the answer! Absolutely take your time with this, no pressure 😄

I'm wondering what would the precedence be for merging various configs, e.g. /usr/share/ -> /etc/ -> $HOME/.config/ and so on?

@patrick330602
Copy link
Member

patrick330602 commented Aug 28, 2022

Right now: /usr/share/wslu/conf -> /usr/share/wslu/custom.conf -> $HOME/.config/wslu/conf -> $HOME/.wslurc;
After this fix: /usr/share/wslu/conf -> /usr/share/wslu/custom.conf -> /etc/wslu/conf -> /etc/wslu/custom.conf -> $HOME/.config/wslu/conf -> $HOME/.wslurc

Document would be here: https://wslutiliti.es/wslu/man/wslu.html#CONFIGURATION

@patrick330602 patrick330602 modified the milestones: 4.0.1, 4.1 Sep 17, 2022
@patrick330602 patrick330602 added the Status: Pending Release This is fixed but not yet released. label Sep 17, 2022
@patrick330602 patrick330602 added Status: Patched This is fixed and is part of a released version. and removed Status: Pending Release This is fixed but not yet released. labels Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This is either an issue that describes ehcmnt./feature or a PR that introduces ehcmnt./feature Status: Patched This is fixed and is part of a released version. Target: 4.x This is targeted to the 4.x release.
Projects
Status: Done
Development

No branches or pull requests

2 participants