Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in Appointment Reservation - Hospital Service #66

Open
isuruuy429 opened this issue Jun 17, 2019 · 0 comments
Open

Issues in Appointment Reservation - Hospital Service #66

isuruuy429 opened this issue Jun 17, 2019 · 0 comments
Assignees
Labels

Comments

@isuruuy429
Copy link
Contributor

Description:
Following issues are found in hospital-service. (ClemencyHospitalService)

Issue 1

When it is added a different hospital(a hospital which doctor is not available) under doctor while appointment reservation, still the appointment is made. Once the appointment details are received through getAppointment, it displays the data of the doctor's original hospital. This is for the already defined doctors in clemency-hospital-service.bal.

Steps to reproduce

  1. Get doctors under category surgery for the already available doctors.
    http://localhost:9090/healthcare/surgery

Following payload is received.

 {
        "name": "anne clement",
        "hospital": "clemency medical center",
        "category": "surgery",
        "availability": "8.00 a.m - 10.00 a.m",
        "fee": 12000
    },
    {
        "name": "thomas collins",
        "hospital": "grand oak community hospital",
        "category": "surgery",
        "availability": "9.00 a.m - 11.00 a.m",
        "fee": 7000
    },
    {
        "name": "seth mears",
        "hospital": "pine valley community hospital",
        "category": "surgery",
        "availability": "3.00 p.m - 5.00 p.m",
        "fee": 8000
    }

2.Reserve the appointment as below. For the hospital provide any bogus value.

{  
	"patient":
	{  
        "name":"K Winslet",
        "dob":"1970-03-19",
        "ssn":"234-987-175",
        "address":"Canada",
        "phone":"32456789765",
        "email":"kwinslet@gmail.com"
    },
	"doctor":"anne clement",
	"hospital":"sdfgh",
	"appointmentDate":"2020-01-22"
}
  1. Check the response payload.
{
    "appointmentNumber": 18,
    "doctor": {
        "name": "anne clement",
        "hospital": "clemency medical center",
        "category": "surgery",
        "availability": "8.00 a.m - 10.00 a.m",
        "fee": 12000
    },
    "patient": {
        "name": "K Winslet",
        "dob": "1970-03-19",
        "ssn": "234-987-175",
        "address": "Canada",
        "phone": "32456789765",
        "email": "kwinslet@gmail.com"
    },
    "fee": 12000,
    "confirmed": false,
    "appointmentDate": "2020-01-22"
}

This issue occurs for the already available doctors only. Once we add a new doctor and retry the same steps following response is received.
'Doctor K Amugoda is not available in clemency medical center'. This should be the expected behavior for already available doctors.

Issue 2

Appointments can be reserved for a past date.

Issue 3

Following fields are not validated.
email address, phone, dob, date

Issue 4

Adding a new doctor is repeated in hospital service which is in healthcare service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants