This repository has been archived by the owner on Oct 5, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing Charon version issue
OAuth2AccessTokenReqDTO oAuth2AccessTokenReqDTO = tokReqMsgCtx.getOauth2AccessTokenReqDTO(); | ||
|
||
if (!StringUtils.isEmpty(oAuth2AccessTokenReqDTO.getClientId()) && | ||
!StringUtils.isEmpty(oAuth2AccessTokenReqDTO.getClientSecret())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of !StringUtils.isEmpty you can use StringUtils.isNotEmpty method
|
||
public abstract class AbstractClientAuthHandler implements ClientAuthenticationHandler { | ||
|
||
Properties properties; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must be protected otherwise will not work for subclasses not in same package
johannnallathamby
added a commit
that referenced
this pull request
Mar 1, 2015
log.error("Cannot find class: " + entry); | ||
} catch (IdentityOAuth2Exception e) { | ||
log.error("Error while initializing " + entry); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'e' is not logged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JKAUSHALYA
pushed a commit
to JKAUSHALYA/carbon-identity
that referenced
this pull request
Nov 17, 2015
fixing jira issue - User does not log out properly when Local Transport ...
JKAUSHALYA
pushed a commit
to JKAUSHALYA/carbon-identity
that referenced
this pull request
Nov 17, 2015
Fix for REGISTRY-2342
DMHP
pushed a commit
to DMHP/carbon-identity
that referenced
this pull request
Jan 3, 2020
…D-65 Fixing WSOTWOSUPPROD-65
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.