Skip to content
This repository has been archived by the owner on Oct 5, 2021. It is now read-only.

Jira3028 #102

Merged
merged 20 commits into from
Mar 1, 2015
Merged

Jira3028 #102

merged 20 commits into from
Mar 1, 2015

Conversation

nuwandiw
Copy link
Contributor

No description provided.

OAuth2AccessTokenReqDTO oAuth2AccessTokenReqDTO = tokReqMsgCtx.getOauth2AccessTokenReqDTO();

if (!StringUtils.isEmpty(oAuth2AccessTokenReqDTO.getClientId()) &&
!StringUtils.isEmpty(oAuth2AccessTokenReqDTO.getClientSecret())) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of !StringUtils.isEmpty you can use StringUtils.isNotEmpty method


public abstract class AbstractClientAuthHandler implements ClientAuthenticationHandler {

Properties properties;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be protected otherwise will not work for subclasses not in same package

johannnallathamby added a commit that referenced this pull request Mar 1, 2015
@johannnallathamby johannnallathamby merged commit 005b459 into wso2-attic:master Mar 1, 2015
log.error("Cannot find class: " + entry);
} catch (IdentityOAuth2Exception e) {
log.error("Error while initializing " + entry);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'e' is not logged

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JKAUSHALYA pushed a commit to JKAUSHALYA/carbon-identity that referenced this pull request Nov 17, 2015
fixing jira issue - User does not log out properly when Local Transport ...
JKAUSHALYA pushed a commit to JKAUSHALYA/carbon-identity that referenced this pull request Nov 17, 2015
DMHP pushed a commit to DMHP/carbon-identity that referenced this pull request Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
7 participants