Skip to content
This repository has been archived by the owner on Oct 5, 2021. It is now read-only.

Resolved IDENTITY-2558 #976

Merged
merged 10 commits into from
Sep 29, 2015
Merged

Resolved IDENTITY-2558 #976

merged 10 commits into from
Sep 29, 2015

Conversation

IndunilRathnayake
Copy link
Contributor

No description provided.

@IndunilRathnayake
Copy link
Contributor Author

Issue: When creating a SP with the federation type as "Federated Authentication" in Local & Outbound Authentication Configuration, the selected federated IDP is saved with current default authenticator. If the default authenticator of IDP is changed afterwards, it is not reflected in SP side. So that when do authentication in SP application, it always authenticated through the saved default authenticator of federated IDP.
Fix: Added a listener to change the IDP's default authenticator in SP side, at the moment of changing IDP configurations.

Other changes:

  1. added a new Exception in idp-mgt module (previously it uses "IdentityApplicationManagementException" defines in application-mgt)
  2. added pre and post methods in ApplicationMgtListener and IdentityProviderMgtLister
  3. Abstract listener for both IdentityProviderMgtLister & ApplicationMgtListener
  4. Throw exception in ConfigurationFacade and catch and log in authentication framework
  5. Change return type of createApplication to void. (The int value returned is the auto-generated table ID which should not be returned, and isn't used anywhere in the client side as well.)

@@ -89,19 +89,19 @@ public static IdentityProviderManager getInstance() {
*
* @param tenantDomain Tenant Domain
* @return Tenant Id of domain user belongs to.
* @throws IdentityApplicationManagementException Error when getting tenant id from tenant
* @throws IdentityProviderManagementException Error when getting tenant id from tenant
* domain
*/
private static int getTenantIdOfDomain(String tenantDomain)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use method in IdentityTenantUtil

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants