Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAML assertion Claims are by default copied to the ID token retrieved with the access token in SAML bearer grant #1387

Open
tharindu-b-hewage opened this issue Mar 24, 2019 · 1 comment
Milestone

Comments

@tharindu-b-hewage
Copy link
Contributor

When an ID token is requested with the SAML bearer grant access token, claim dialect for the claims included in the SAML assertion are directly copied in the default pack.

If the SAML assertion contained a claim in the local dialect, it will not be converted to the oidc dialect by default. This is due to the configuration option, <ConvertOriginalClaimsFromAssertionsToOIDCDialect> is disabled by default.

Above config is introduced with Handling Custom Claims with the JWT Bearer Grant Type and explained in the doc, which needs to be linked/explained in https://docs.wso2.com/display/IS580/Setting+up+a+SAML2+Bearer+Assertion+Profile+for+OAuth+2.0

@darshanasbg
Copy link
Contributor

darshanasbg commented Mar 24, 2019

Better to have ConvertOriginalClaimsFromAssertionsToOIDCDialect config set to true in default pack.

If so, have to explain this behavior change in the migration guide.

@madurangasiriwardena madurangasiriwardena transferred this issue from wso2/product-is Mar 3, 2020
@madurangasiriwardena madurangasiriwardena added this to the 5.10.0-GA milestone Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants