Please update samples structure of netty-transports yaml file

[suchostone]

Description:

Using the below netty-transports file, getting following error:

Unable to find property 'bossThreadPoolSize' on class: org.wso2.carbon.transport.http.netty.config.ListenerConfiguration
in 'reader', line 21, column 23:
bossThreadPoolSize: 2

The same happens for workerThreadPoolSize

I had to remove both properties from netty-transports.yml file to make it work.
Now, using thread pooling configuration from deployment.yaml

Affected Product Version:
2.4.X

OS, DB, other environment details and versions:
macos high Sierra 10.13

Steps to reproduce:
Run the built fat jar from target directory with -Dtransports.netty.conf=netty-transports.yml

netty-transports.yml:

listenerConfigurations:

id: "msf4j-http"
host: "127.0.0.1"
port: 8080
bossThreadPoolSize: 2
workerThreadPoolSize: 250
parameters:
-
name: "execThreadPoolSize"
value: 60

• id: "msf4j-https"
  host: "127.0.0.1"
  port: 8443
  bossThreadPoolSize: 2
  workerThreadPoolSize: 250
  scheme: https
  keyStoreFile: "conf/wso2carbon.jks"
  keyStorePass: wso2carbon
  certPass: wso2carbon

[thusithathilina]

@suchostone Your configuration yaml format is invalid with the latest version. You can refer to the sample config file bundle with MSF4J on https://github.com/wso2/msf4j/blob/v2.4.2/distribution/binary/conf/netty-transports.yml

[suchostone]

@thusithathilina hi Tusitha, thanks for your reply. Yes, I know the configuration I shared is not aligned with latest version, thats why I had to tweak to make it work. My point in this issue, as the subject states, is to "update" samples structure of netty yaml file, for example in stockquote fat-jar sample, msf4j version is 4.2.X and netty-transports file is still making reference to old structure.
Thanks.

[thusithathilina]

@suchostone Thanks for pointing that out
@daneshk Seems we missed to update the yaml in stockquote sample :( Can we mark this as a bug ?

[daneshk]

Thanks @suchostone @thusithathilina. I will fix it in the next release.