docker-compose.yml & Dockerfile cleanup.

[FlynDice]

docker-compose already has the host current dir mapped to /code so there
is no need for COPY . /code/ to copy the code into the dockerfile.

WORKDIR /code is set in the dockerfile so docker-compose can just use
./manage.py to run the server.

Changed the README.md to use docker-compose build vs docker build . as
the build parameters are contained in the docker-compose.yml file.

[phoikoi]

If you want to create an image to be deployed, you can't rely on the /code directory being mounted, it needs to be copied in. The docker-compose file will overlay the copied code with the mount, which works for local development, but to build a deployable image, that COPY needs to be there.

[FlynDice]

If by deployable you mean directly pullable as an image from a repository then I would agree with you, but I thought this was more of a beginner/starter template where using mounted directories makes things easier to work/tinker with. It is simple enough to add a production.yml file to build a container/stack with copied code & no mounted dirs for that purpose if that is what you need...

[Hesham-Aboalsoud]

I get this error "django.db.utils.OperationalError: could not translate host name "db" to address: Name or service not known" I don't know what it's The problem

…

On Sun, Nov 1, 2020, 1:30 AM FlynDice ***@***.***> wrote: If by deployable you mean directly pullable as an image from a repository then I would agree with you, but I thought this was more of a beginner/starter template where using mounted directories makes things easier to work/tinker with. It is simple enough to add a production.yml file to build a container/stack with copied code & no mounted dirs for that purpose if that is what you need... — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#38 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APYDTUTUM2WSAHM7REUVFE3SNSM2XANCNFSM4SFDXZXA> .

[FlynDice]

Well there's no db service in the docker-compose.yml file. I'm guessing you somehow changed the DATABASES variable in the settings.py file to something with a host name of "db" and django can't find it...

[wsvincent]

Hi @FlynDice, You're right the db service is left out for some reason. (Obviously an error on my part.) Going to fix now. Thanks all for the discussion.