Use case for hideElements

[nathasm]

I have a page that contains the following snippet:

<div id="infoGraphics">....</div>

Using chrome devtools:

document.querySelectorAll('div#infoGraphics').length
-> 1

In writing my test I have a getter in my page object like:

get infoGraphic() { return $('div#infoGraphics'); }

And my test:

browser.saveScreen('LoginPage', { hideElements: [ LoginPage.infoGraphic ] });

Which fails with:

Cannot set property 'visibility' of undefined

However, if I use the following, my test will work:

get infoGraphic() { return $$('div#infoGraphics'); }

Is this expected? Or have I misused the API?

[wswebcreation]

Hi @nathasm

That is strange, I'll take a look, but it should work. Let me get back to this

[wswebcreation]

Issue is in here

webdriver-image-comparison/lib/clientSideScripts/hideRemoveElements.ts

Line 5 in 60e91fb

hideRemoveElements.hide.forEach(element => element.style.visibility = hideRemove ? 'hidden' : '');

Need to find some time and fix it

[wswebcreation]

@nathasm

I've release https://github.com/wswebcreation/wdio-image-comparison-service/releases/tag/v1.12.1, can you please check again?

[wswebcreation]

@nathasm

Did you already had time to check it again? I think it might be fixed now.

[Christopher-Hayes]

I'm having the same issue with multiple classes $('.classA.classB'). I'm gonna try upgrading to v1.12.1 (v1.9.0 right now) and report back if that issue is fixed.

Somewhat related, could we make this fail gracefully by still taking the screenshot? I have elements that only exist on certain pages and the library not finding one of the remove elements causes the screenshot to never be taken. For now I create a removeElements array by first checking isDisplayed() before passing that to the saveFullPageScreen() function.

LMK if this ^ is a possibility, I can go ahead and make that into a separate ticket.

[wswebcreation]

@Christopher-Hayes

Good suggestion, please make a separate ticket for it

[wswebcreation]

Closing this issue because I believe it is fixed