Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing 'q' in text input modal quits the app #1257

Closed
lsipii opened this issue Jun 20, 2022 · 2 comments · Fixed by #1272
Closed

Pressing 'q' in text input modal quits the app #1257

lsipii opened this issue Jun 20, 2022 · 2 comments · Fixed by #1272
Assignees
@senorprogrammer
Labels
🐛 bug "Houston, we've had a problem."

Comments

@lsipii
Copy link
Contributor

lsipii commented Jun 20, 2022

What's broken?

Text input modal, used in for example Todo-module, quits the whole application when inputting a letter 'q'.
@lsipii
Copy link
Contributor Author

lsipii commented Jun 20, 2022 •
edited
Loading

The q-keypress listerer at wtf_app.go should maybe be a bit more context aware.

Edit: the easiest fix would be to wrap the quit-call with the !wtfApp.focusTracker.IsFocused condition, but that seems to track wheter any module is active. A more useful condition would be one that checks if any text-input is focused.

@senorprogrammer senorprogrammer added the 🐛 bug "Houston, we've had a problem." label Jul 5, 2022
@senorprogrammer senorprogrammer self-assigned this Jul 10, 2022
@senorprogrammer senorprogrammer mentioned this issue Jul 10, 2022
Merged
@senorprogrammer
Copy link
Collaborator

v0.42.0 has been released, which fixes this https://github.com/wtfutil/wtf/releases/tag/v0.42.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@senorprogrammer senorprogrammer

Labels
🐛 bug "Houston, we've had a problem."
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WTF-1257 Only quit on q if nothing has focus wtfutil/wtf
2 participants
@senorprogrammer @lsipii