Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site: Add hackernews functionality #12

Closed
ginglis13 opened this issue Jul 26, 2019 · 3 comments · Fixed by #59
Closed

Site: Add hackernews functionality #12

ginglis13 opened this issue Jul 26, 2019 · 3 comments · Fixed by #59
Assignees
@ginglis13
Labels
enhancement help wanted

Comments

@ginglis13
Copy link
Collaborator

ginglis13 commented Jul 26, 2019 •
edited

see title
@ginglis13
Copy link
Collaborator Author

link to API

@sambattalio sambattalio added this to the v2 milestone Jul 31, 2019
@sambattalio sambattalio removed this from the v2 milestone Jul 31, 2019
@ginglis13
Copy link
Collaborator Author

Looking into this more now. The official API is honestly not great. To get things working the way we would want, we would need to make multiple calls chained together. For example, a request for Top Stories simply returns a list of story IDS. A request on these story IDs returns title, url, and a list of comment IDs, along w some other info. A request for comment IDs can contain child comment IDs, which would require yet another API call to get information about, and so on.

Maybe we could use the tree view but have comments that are below the top tier comments hidden by default, with a number next to the parent comment indicating how many child comments there are. We could then only load child comments when a user selects to expand the tree view.

Not sure how the best way to handle this will be, open to ideas @wtheisen @sambattalio .

@ginglis13 ginglis13 self-assigned this Aug 10, 2019
@ginglis13
Copy link
Collaborator Author

Got a WIP going

@ginglis13 ginglis13 mentioned this issue Aug 12, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ginglis13 ginglis13

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hackernews ginglis13/TerminusBrowser
2 participants
@sambattalio @ginglis13