Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests failing due to Styled-Components #152

Closed
Nayshlok opened this issue Apr 23, 2018 · 1 comment
Closed

Unit tests failing due to Styled-Components #152

Nayshlok opened this issue Apr 23, 2018 · 1 comment

Comments

@Nayshlok
Copy link
Contributor

The snapshots seem to be failing now because the styledcomponent names are more random. Because the snapshot includes them and they are being generated each time we can't get a passing build.

@aabenoja
Copy link
Contributor

This doesn't appear to be an issue. The latest master is building just fine. I pushed up a copy of your branch with a revert of your snapshot updates. Since the build is passing I'm pretty sure this is a non issue and can be safely closed.

We're currently locked to styled-components@^2.4.0, which was released back in January and they're currently on v3.2.6, so we can rule out a version mismatch unless you were somehow on an older version. I don't know what else could have caused your hiccup.

Feel free to reopen once you've found more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants