Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rest mapping such as GetMapping #491

Merged
merged 1 commit into from Oct 8, 2017
Merged

add rest mapping such as GetMapping #491

merged 1 commit into from Oct 8, 2017

Conversation

clevertension
Copy link
Contributor

add rest mapping such as GetMapping, PostMapping....

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 18.201% when pulling 423efc1 on clevertension:my-main into a2d2f41 on wu-sheng:master.

@wu-sheng
Copy link
Member

wu-sheng commented Oct 8, 2017

Related to #465

wu-sheng
wu-sheng approved these changes Oct 8, 2017
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please just post some sample codes and trace stack snapshot.

@wu-sheng wu-sheng added this to the 3.2.3-2017 milestone Oct 8, 2017
@clevertension
Copy link
Contributor Author

image
this is the sample controller mapping

@clevertension
Copy link
Contributor Author

image
this is the track span message with the @RequestMapping, and @GetMapping annotation

@wu-sheng wu-sheng merged commit 8eed412 into apache:master Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.3-2017
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clevertension @coveralls @wu-sheng