Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sudo allowances #2

Closed
brianjmurrell opened this issue Jan 4, 2019 · 2 comments
Closed

sudo allowances #2

brianjmurrell opened this issue Jan 4, 2019 · 2 comments

Comments

@brianjmurrell
Copy link

brianjmurrell commented Jan 4, 2019

I'm not sure that the existing sudo allowances should be allowed by default. Perhaps they should be approved by the admin.

The restart permission I'm not so worried about but the mount permission seems a bit sketchy.

I realise we are inheriting this from Emby, but perhaps we should be more cautious. I, for example, have no use or interest in mounting ISO images and would rather not give mount permissions to something that doesn't need it.

@Wuerfelbecher
Copy link
Owner

I agree with you on every point you made, since i mostly copied the official debian package, which i even did wrong since i forgot to add the -restartpath option to the daemon, so the policy was unused.

I updated the .spec release to print to:

  • print a message after installation
  • moved the sudo policy to /usr/share/jellyfin/jellyfin-sudoers
  • /etc/sudoers.d/jellyfin should be removed by RPM (due to spec bump)
  • commented out the mount part of the policy

Thank you very much for pointing this out!

@brianjmurrell
Copy link
Author

Looks good. I really like the idea of using systemd's to detect when Jellyfin wants to restart itself.

Nice job getting this on RH distros by the way. Really appreciate that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants