Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requested Changes Connection API #299

Open
4 of 8 tasks
cb0s opened this issue Jun 30, 2021 · 1 comment
Open
4 of 8 tasks

Requested Changes Connection API #299

cb0s opened this issue Jun 30, 2021 · 1 comment
Assignees
@cb0s
Labels
📄 java Pull requests that update Java code 🎩 telestion-services Everything related to the telestion-services module 🌷 enhancement New feature or request
Projects
Telestion
Milestone
v0.10

Comments

@cb0s
Copy link
Member

cb0s commented Jun 30, 2021 •
edited

In a conversation with @fussel178 we noticed that the following things should be implemented as soon as possible to make the new connection API more useable.

  • Remove "rework" from package name to ensure that there will be only one breaking change as soon as the old API vanishes (as stated in Clean Connection API #267)
  • Add documentation to make the concept and the usage of the API more clear (currently it is very complicated to understand and might not be used in the intended way)
  • Add broadcast functionality
    • For one specific interface type
    • For all net-interfaces
  • Publish when new TCP-connection has been established (with the correct tcp-details, to inform everybody of the new connection which can be addressed)
  • TcpDispatcher: Make config loading possible (e.g. with "FactoryVerticle" whose job is to deploy all the other required verticles)
  • Add package-info where required
@cb0s cb0s added 🌷 enhancement New feature or request telestion 📄 java Pull requests that update Java code labels Jun 30, 2021
@cb0s cb0s self-assigned this Jun 30, 2021
@cb0s cb0s added this to To Do in Telestion via automation Jun 30, 2021
@fussel178 fussel178 moved this from To Do to Backlog - New Unranked in Telestion Jun 30, 2021
@fussel178 fussel178 added 🎩 telestion-services Everything related to the telestion-services module and removed telestion labels Jul 21, 2021
@jvpichowski jvpichowski moved this from Backlog - New Unranked to pre-v1.0 in Telestion Jul 28, 2021
@cb0s cb0s mentioned this issue Aug 1, 2021
Closed
1 task
@cb0s cb0s linked a pull request Aug 1, 2021 that will close this issue
Improve Connection API #346
Closed
1 task
@cb0s
Copy link
Member Author

cb0s commented Nov 16, 2021 •
edited

@fussel178 @jvpichowski @pklaschka what do you think? Should there be a "message" on the eventBus if a packet gets dropped? There are special cases (e.g. when the client refuses as it closed the connection) where it might be useful to at least have the possibility to react on it.
Do you think this could be useful?

@cb0s cb0s moved this from pre-v1.0 to Sprint in Telestion Nov 17, 2021
@fussel178 fussel178 moved this from Sprint to pre-v1.0 in Telestion Jan 27, 2022
@fussel178 fussel178 added this to the v0.9 milestone Jan 31, 2022
@fussel178 fussel178 modified the milestones: v0.9, v0.10 Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cb0s cb0s

Labels
📄 java Pull requests that update Java code 🎩 telestion-services Everything related to the telestion-services module 🌷 enhancement New feature or request
Projects
Telestion
v1.0
Milestone
v0.10
Development

Successfully merging a pull request may close this issue.

Improve Connection API wuespace/telestion-core
2 participants
@cb0s @fussel178